This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.araujo
Recipients eric.araujo, higery, jhylton, santoso.wijaya, tarek
Date 2011-04-18.17:25:22
SpamBayes Score 0.00010412127
Marked as misclassified No
Message-id <1303147522.82.0.686111753763.issue828450@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch.  Follow the “review” link above to find my review.

+1 on making the smallest possible change.  The paths inside the Filelist/Manifest objects can continue to use os.sep, we only care about write_file for this bug.  Oh, and also read_file: can you add tests for MANIFEST reading?  It will be a bit more complicated: write a MANIFEST file with /-separated paths, set os.sep to \\, check that sdist works.  You should learn a lot about our tests helpers (mostly TempdirManager).
History
Date User Action Args
2011-04-18 17:25:22eric.araujosetrecipients: + eric.araujo, jhylton, tarek, santoso.wijaya, higery
2011-04-18 17:25:22eric.araujosetmessageid: <1303147522.82.0.686111753763.issue828450@psf.upfronthosting.co.za>
2011-04-18 17:25:22eric.araujolinkissue828450 messages
2011-04-18 17:25:22eric.araujocreate