Message133985
Thanks for the patch. Follow the “review” link above to find my review.
+1 on making the smallest possible change. The paths inside the Filelist/Manifest objects can continue to use os.sep, we only care about write_file for this bug. Oh, and also read_file: can you add tests for MANIFEST reading? It will be a bit more complicated: write a MANIFEST file with /-separated paths, set os.sep to \\, check that sdist works. You should learn a lot about our tests helpers (mostly TempdirManager). |
|
Date |
User |
Action |
Args |
2011-04-18 17:25:22 | eric.araujo | set | recipients:
+ eric.araujo, jhylton, tarek, santoso.wijaya, higery |
2011-04-18 17:25:22 | eric.araujo | set | messageid: <1303147522.82.0.686111753763.issue828450@psf.upfronthosting.co.za> |
2011-04-18 17:25:22 | eric.araujo | link | issue828450 messages |
2011-04-18 17:25:22 | eric.araujo | create | |
|