Message133906
Here's a patch that fixes the reported bug (calling close twice fails with an AttributeError) the simple way.
Note that there was actually a test for the buggy behavior, which is rather odd considering that there is also a 'closed' method that would fail similarly if close was ever called. (The only use for the existing 'closed' method that I can see is to see if somebody else closed the file out from under the ProxyFile, a 'feature' that seems of dubious utility.)
It seems clear to me that calling close more than once should be legal, so I fixed the test. closed will still report if the underlying file has been closed out from under ProxyFile.
Steffen, I still don't understand what you are trying to achieve with your patches. I plan to close this issue by applying my patch. |
|
Date |
User |
Action |
Args |
2011-04-16 20:17:30 | r.david.murray | set | recipients:
+ r.david.murray, twouters, georg.brandl, amaury.forgeotdarc, sdaoden |
2011-04-16 20:17:30 | r.david.murray | set | messageid: <1302985050.59.0.848109362051.issue11700@psf.upfronthosting.co.za> |
2011-04-16 20:17:29 | r.david.murray | link | issue11700 messages |
2011-04-16 20:17:29 | r.david.murray | create | |
|