Message132502
This new patch adheres your suggestion.
Now all implemented operations perform
a "file is open at all" check and raise
ValueError if not, which somewhat reflects
what i've seen when i was looking into fileio.c.
My questions:
- shouldn't _ProxyFile inherit from
a real Python I/O class, for example IOBase?
Like this it would stand in a line where it belongs.
I could do that (not much missing for that).
- I have no idea of the test framework. The last hour
i tried to adjust test_mailbox.py a bit, but it's hard.
It's not about design and it's not about algorithm. Uff.
I could nonetheless add some cases to yet existing
test functions and change another one. But this needs
a real eye on it!
(For example: is there a AssertNoRaises?) |
|
Date |
User |
Action |
Args |
2011-03-29 19:11:06 | sdaoden | set | recipients:
+ sdaoden, twouters, georg.brandl, amaury.forgeotdarc, r.david.murray |
2011-03-29 19:11:06 | sdaoden | set | messageid: <1301425866.04.0.648168019076.issue11700@psf.upfronthosting.co.za> |
2011-03-29 19:11:03 | sdaoden | link | issue11700 messages |
2011-03-29 19:11:03 | sdaoden | create | |
|