This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients ghaering, pitrou, torsten
Date 2011-03-27.14:31:53
SpamBayes Score 3.8032404e-08
Marked as misclassified No
Message-id <1301236314.1.0.185393931145.issue11688@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch.

A couple of comments:
- this is a new feature, so can only go in in 3.x: no need to post a 2.7 patch (unless this helps Gerhard for his standalone project)
- you need to document the new API in Doc/library/sqlite3.rst

About the patch: looks mostly good!

+        self.assertTrue([x for x in traced_statements if x.find("create table foo") != -1])

This looks a bit complicated, why not something like
`any("create table foo" in x for x in traced_statements)`?

(`y in x` is simper and more readable than `x.find(y) != -1`)


+        sqlite3_trace(self->db, _trace_callback, trace_callback);
+        if (PyDict_SetItem(self->function_pinboard, trace_callback, Py_None) == -1)
+            return NULL;

Shouldn't sqlite3_trace() be called only after PyDict_SetItem() succeeds?
History
Date User Action Args
2011-03-27 14:31:54pitrousetrecipients: + pitrou, ghaering, torsten
2011-03-27 14:31:54pitrousetmessageid: <1301236314.1.0.185393931145.issue11688@psf.upfronthosting.co.za>
2011-03-27 14:31:53pitroulinkissue11688 messages
2011-03-27 14:31:53pitroucreate