Message131997
@orsenthil
> Close similarity with getpass.c 's behavior had lent some to support to this change in 2.6. Changing now in older codeline has some chances of breaking others code.
> Someone who has been affected by this change in behavior should provide some insights if back-porting would make sense.
Most code will probably have been updated their getpass code with a line like
if '\x03' in text:
raise KeyboardInterrupt()
( http://www.mediawiki.org/wiki/Special:Code/pywikipedia/8978 )
However, people might have changed their code from
try:
pass = getpass.getpass()
except KeyboardInterrupt:
print "Ctrl-C!"
to:
pass = getpass.getpass()
if "\x03' in pass:
print "Ctrl-C!"
which will break with this change. The first workaround makes more sense, though, so I suspect very little code will be broken by reverting the ISIG flag.
Overall, I think most people are not aware of the removal, either because they still use python 2.5 or because they don't press ctrl-c. They are still in for a surprise if the ISIG flag is not removed (although it will probably stay in the 2.6 branch, anyway?). |
|
Date |
User |
Action |
Args |
2011-03-24 16:12:18 | valhallasw | set | recipients:
+ valhallasw, gregory.p.smith, belopolsky, orsenthil, pitrou, benjamin.peterson, pajs@fodder.org.uk, eric.araujo, asvetlov, sdaoden, python-dev |
2011-03-24 16:12:17 | valhallasw | set | messageid: <1300983137.38.0.162482038574.issue11236@psf.upfronthosting.co.za> |
2011-03-24 16:12:16 | valhallasw | link | issue11236 messages |
2011-03-24 16:12:16 | valhallasw | create | |
|