Author eric.araujo
Recipients brett.cannon, carljm, eric.araujo
Date 2011-03-21.23:12:34
SpamBayes Score 0.000158867
Marked as misclassified No
Message-id <1300749156.12.0.655531718025.issue11591@psf.upfronthosting.co.za>
In-reply-to
Content
Looks great, thank you.  I think I’ll also add a docstring to main before committing, now that the function is publicly documented.

Did you have to manually click “Create Patch” to make roundup generate it?  Did you try first to click on the button of the existing repo before adding a new repo entry?  (Still learning how to use it, thanks for experimenting along :)

Brett: Thanks for the review.  If you don’t comment negatively on the doc change, I will commit this.

(Side concern: the module does not define __all__, even though only 4 functions and 4 constants are officially documented.  I’d like to define __all__, but the recentish huge thread on public/private APIs scared me.)
History
Date User Action Args
2011-03-21 23:12:36eric.araujosetrecipients: + eric.araujo, brett.cannon, carljm
2011-03-21 23:12:36eric.araujosetmessageid: <1300749156.12.0.655531718025.issue11591@psf.upfronthosting.co.za>
2011-03-21 23:12:34eric.araujolinkissue11591 messages
2011-03-21 23:12:34eric.araujocreate