Author bialix
Recipients benjamin.peterson, bialix, eric.araujo
Date 2011-03-21.13:16:34
SpamBayes Score 4.11995e-05
Marked as misclassified No
Message-id <1300713395.03.0.158637003307.issue11594@psf.upfronthosting.co.za>
In-reply-to
Content
Éric, thank you for the proposal, but I'm not familiar enough with the codebase to work on it. 

The short scan over the tests reveals that there is at least one test which tries to test CRLF behavior, in the file test_refactor.py, but I don't understand what it doing?

    def test_crlf_newlines(self):
        old_sep = os.linesep
        os.linesep = "\r\n"
        try:
            fn = os.path.join(TEST_DATA_DIR, "crlf.py")
            fixes = refactor.get_fixers_from_package("lib2to3.fixes")
            self.check_file_refactoring(fn, fixes)
        finally:
            os.linesep = old_sep

So, in theory I can modify that test to check what if the file has LF-only line-endings originally, but os.linesep is CRLF, but then I don't know what the content I should create and how to run fixer over that.
History
Date User Action Args
2011-03-21 13:16:35bialixsetrecipients: + bialix, benjamin.peterson, eric.araujo
2011-03-21 13:16:35bialixsetmessageid: <1300713395.03.0.158637003307.issue11594@psf.upfronthosting.co.za>
2011-03-21 13:16:34bialixlinkissue11594 messages
2011-03-21 13:16:34bialixcreate