Message131453
On Sat, Mar 19, 2011 at 01:29:28PM +0000, Éric Araujo wrote:
> It’s a private function, if that makes the patch smaller let’s change it.
The promised 11466.5.patch. It:
- Fixes #11466 resource warning.
- Fixes bogus newline which would have been written before
in case the fallback implementation needs to be used.
+ _raw_input() has been renamed to _user_input() because that
is what it actually does (wether it's raw depends on caller).
It will now encapsulate the complete user prompting,
thus including the mentioned final newline.
- Allows patch-in of #11236 patch without any further
adjustments (i.e. no additional catch of another resource
warning necessary).
- It cleans up the control flow and the comments a bit which
i think was the reason that the first two items above could
actually become introduced in the code at all.
But - it's even larger than 11466.4.patch! |
|
Date |
User |
Action |
Args |
2011-03-19 22:40:58 | sdaoden | set | recipients:
+ sdaoden, gregory.p.smith, eric.araujo |
2011-03-19 22:40:58 | sdaoden | link | issue11466 messages |
2011-03-19 22:40:58 | sdaoden | create | |
|