Author brian.curtin
Recipients SilentGhost, Winston.Ewert, brian.curtin, daniel.urban, ezio.melotti, michael.foord, ncoghlan, r.david.murray, rhettinger, robquad
Date 2011-03-15.13:17:15
SpamBayes Score 6.06617e-06
Marked as misclassified No
Message-id <1300195036.08.0.677792387394.issue10775@psf.upfronthosting.co.za>
In-reply-to
Content
I showed robquad how to do the review stuff at PyCon but I forgot about the publish part. Robbie, if you hit "Publish + Mail Comments" near the top of the page after you've left comments, it'll send them out.


What he noticed was that changing to callable_obj in the assertRaises signature could break anyone who had been using callableObj as a named argument. Although it isn't explicitly documented, it's a named argument that someone is probably using. As for standardizing, it's probably best to match the general format of the library which is camelCase, and change the internal uses rather than a public method signature.
History
Date User Action Args
2011-03-15 13:17:16brian.curtinsetrecipients: + brian.curtin, rhettinger, ncoghlan, ezio.melotti, r.david.murray, michael.foord, SilentGhost, daniel.urban, Winston.Ewert, robquad
2011-03-15 13:17:16brian.curtinsetmessageid: <1300195036.08.0.677792387394.issue10775@psf.upfronthosting.co.za>
2011-03-15 13:17:15brian.curtinlinkissue10775 messages
2011-03-15 13:17:15brian.curtincreate