Message130585
About dedup_const_planb.patch: _PyCode_AddObj() should be added to Include/code.h, even if it's private (rather than declared extern in peephole.c).
About consts_test.patch: "def mapping" deserves a better name, and perhaps a comment or explanation. Same for "def fix".
About unused_consts.patch:
- code like
constuse = (int *)PyMem_Malloc(numconst * sizeof(int));
is better spelt
constuse = PyMem_NEW(int, numconst);
- why the "#ifndef NDEBUG" path?
You probably need to regenerate this patch against latest hg, by the way...
Thanks for posting this. |
|
Date |
User |
Action |
Args |
2011-03-11 16:35:13 | pitrou | set | recipients:
+ pitrou, rhettinger, mark.dickinson, eltoder |
2011-03-11 16:35:13 | pitrou | set | messageid: <1299861313.47.0.232146644624.issue11462@psf.upfronthosting.co.za> |
2011-03-11 16:35:12 | pitrou | link | issue11462 messages |
2011-03-11 16:35:12 | pitrou | create | |
|