Author pitrou
Recipients eltoder, mark.dickinson, pitrou, rhettinger
Date 2011-03-11.16:35:12
SpamBayes Score 3.4181e-07
Marked as misclassified No
Message-id <1299861313.47.0.232146644624.issue11462@psf.upfronthosting.co.za>
In-reply-to
Content
About dedup_const_planb.patch: _PyCode_AddObj() should be added to Include/code.h, even if it's private (rather than declared extern in peephole.c).

About consts_test.patch: "def mapping" deserves a better name, and perhaps a comment or explanation. Same for "def fix".

About unused_consts.patch:

- code like
    constuse = (int *)PyMem_Malloc(numconst * sizeof(int));
is better spelt
    constuse = PyMem_NEW(int, numconst);

- why the "#ifndef NDEBUG" path?

You probably need to regenerate this patch against latest hg, by the way...
Thanks for posting this.
History
Date User Action Args
2011-03-11 16:35:13pitrousetrecipients: + pitrou, rhettinger, mark.dickinson, eltoder
2011-03-11 16:35:13pitrousetmessageid: <1299861313.47.0.232146644624.issue11462@psf.upfronthosting.co.za>
2011-03-11 16:35:12pitroulinkissue11462 messages
2011-03-11 16:35:12pitroucreate