Message130492
Nice work! Is there a specific place for comments? Here are some of them already:
- Modules/zipimport.c::make_filename: remove the limit buffer, the code could
look like:
pathsize = PyUnicode_GET_SIZE(prefix) + PyUnicode_GET_SIZE(name);
result = PyUnicode_FromUnicode(NULL, pathsize);
path = PyUnicode_AS_UNICODE(ret);
...
return result;
- Python/importdl.c::_PyImport_LoadDynamicModule: shortnameobj is not necessary:
lastdot = Py_UNICODE_strrchr(nameuni, '.');
if (lastdot == NULL)
shortname = namenuni;
else:
shortname = lastdot + 1;
- _PyImport_GetDynLoadFunc still takes char* arguments. Can this fail on win32
for example, in case the pathname cannot be encoded to mbcs? |
|
Date |
User |
Action |
Args |
2011-03-10 08:01:21 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, brett.cannon, georg.brandl, terry.reedy, ncoghlan, belopolsky, pitrou, vstinner, benjamin.peterson, eric.araujo, Arfrever, r.david.murray |
2011-03-10 08:01:21 | amaury.forgeotdarc | set | messageid: <1299744081.7.0.841174617299.issue3080@psf.upfronthosting.co.za> |
2011-03-10 08:01:21 | amaury.forgeotdarc | link | issue3080 messages |
2011-03-10 08:01:20 | amaury.forgeotdarc | create | |
|