Author twouters
Recipients pitrou, twouters
Date 2011-03-06.21:36:08
SpamBayes Score 3.17191e-13
Marked as misclassified No
Message-id <>
The cygwin changes are no-ops, just refactoring the needlessly nested if statement for clarity. I can revert them.

The getargs.c change *is* necessary, although it doesn't have to be that exact change. The problem is that the functions in that block are not declared in any file in Include/, although I don't know why not (it's true that these function shouldn't be called directly, but they are symbols that should be exported. The ifdef the patch removes makes the export happen only for Windows, but I see no reason to do that conditionally.) To be clear, the #define of (for example) PyArg_Parse to _PyArg_Parse_SizeT in Include/modsupport.h doesn't apply, because Python/getargs.c does not (and must not) define PY_SSIZE_T_CLEAN (or we wouldn't be able to define both PyArg_Parse and _PyArg_Parse_SizeT.)

We could just list these functions in Include/modsupport.h, along with the 'public' (non-PY_SSIZE_T_CLEAN) ones -- but that only makes sense if  we want code to call the ssize_t functions directly, which I don't think we want.
Date User Action Args
2011-03-06 21:36:09twouterssetrecipients: + twouters, pitrou
2011-03-06 21:36:09twouterssetmessageid: <>
2011-03-06 21:36:08twouterslinkissue11410 messages
2011-03-06 21:36:08twouterscreate