Author sdaoden
Recipients giampaolo.rodola, pitrou, sdaoden
Date 2011-02-28.14:49:28
SpamBayes Score 2.18906e-08
Marked as misclassified No
Message-id <20110228144837.GD74538@sherwood.local>
In-reply-to <1298903836.51.0.0360506310736.issue11351@psf.upfronthosting.co.za>
Content
Will this do?  Otherwise feel free to adjust the patch the way 
Python needs it, i'll learn from that, then, for possible future 
things.  (I need to go down now.)

On Mon, Feb 28, 2011 at 02:37:16PM +0000, Antoine Pitrou wrote:
> 
> Antoine Pitrou <pitrou@free.fr> added the comment:
> 
> Your patch is not cleaned up. There are strange things like:
> 
> +            ret ^= ret;
> 
> (while would you xor an off_t?)
> 
> and
> 
> +        do {    off_t x = (*buf)[i].len;
> +                (*iov)[i].iov_len = x;
> +                ret += x;
> +        } while (0);
Files
File name Uploaded
issue11351.patch sdaoden, 2011-02-28.14:49:28
History
Date User Action Args
2011-02-28 14:49:30sdaodensetrecipients: + sdaoden, pitrou, giampaolo.rodola
2011-02-28 14:49:28sdaodenlinkissue11351 messages
2011-02-28 14:49:28sdaodencreate