Author pitrou
Recipients giampaolo.rodola, pitrou, sdaoden
Date 2011-02-28.14:37:15
SpamBayes Score 0.104905
Marked as misclassified No
Message-id <1298903836.51.0.0360506310736.issue11351@psf.upfronthosting.co.za>
In-reply-to
Content
Your patch is not cleaned up. There are strange things like:

+            ret ^= ret;

(while would you xor an off_t?)

and

+        do {    off_t x = (*buf)[i].len;
+                (*iov)[i].iov_len = x;
+                ret += x;
+        } while (0);
History
Date User Action Args
2011-02-28 14:37:16pitrousetrecipients: + pitrou, giampaolo.rodola, sdaoden
2011-02-28 14:37:16pitrousetmessageid: <1298903836.51.0.0360506310736.issue11351@psf.upfronthosting.co.za>
2011-02-28 14:37:15pitroulinkissue11351 messages
2011-02-28 14:37:15pitroucreate