Message129108
My first idea was to make the argument a tuple to match socket.create_connection(), but SMTP uses host and port arguments, for consistency it's better havin separate source_ip and source_port arguments. As a side effect, it makes easier to specify only source_port.
The submited patch includes tests and updated docstrings;
At the smtplib.rst, for example:
SMTP(host='', port=0, local_hostname=None[, timeout])
Would be ok to change it like:
SMTP(host='', port=0, local_hostname=None[, timeout], source_ip='', source_port=0) |
|
Date |
User |
Action |
Args |
2011-02-22 18:33:40 | paulos | set | recipients:
+ paulos, giampaolo.rodola, r.david.murray |
2011-02-22 18:33:40 | paulos | set | messageid: <1298399620.45.0.164700212287.issue11281@psf.upfronthosting.co.za> |
2011-02-22 18:33:39 | paulos | link | issue11281 messages |
2011-02-22 18:33:39 | paulos | create | |
|