Author r.david.murray
Recipients barry, docs@python, r.david.murray, xmorel
Date 2011-02-21.21:32:16
SpamBayes Score 2.65849e-09
Marked as misclassified No
Message-id <1298323936.96.0.486295212559.issue11260@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for taking an interest in this and working up a patch.  Unfortunately I do have some concerns.

As far as I know the only module that currently uses argparse is compileall, which was only changed recently.

Do tests currently exist for smtpd run as a script?  If not, our experience with converting compileall to argparse indicates a thorough test suite is needed (and even so we missed some things we hadn't thought to test).

We converted compileall because its help output was broken, but in retrospect it might have been better to fix the help output in the existing code.  In other words, if the current code works, is "updating" it a sufficient reason to change it, considering the chances of introducing new bugs?  The answer might be yes, but I don't think it is obviously yes.
History
Date User Action Args
2011-02-21 21:32:17r.david.murraysetrecipients: + r.david.murray, barry, xmorel, docs@python
2011-02-21 21:32:16r.david.murraysetmessageid: <1298323936.96.0.486295212559.issue11260@psf.upfronthosting.co.za>
2011-02-21 21:32:16r.david.murraylinkissue11260 messages
2011-02-21 21:32:16r.david.murraycreate