Message128731
Here are couple of Review Comments on What's new document.
1. The logging dictConfig example fails if you try directly out-of-text.
The conf file is opened as a 'rb' and json module throws an error as "TypeError: can't use a string pattern on a bytes-like object". Suggestion - Just reading it as string is fine.
Also, this example throws another error from json, when you read it as string.
ValueError: Expecting property name: line 4 column 17 (char 204)
I was able to fix it by simplifying the conf.json, but I think the current one itself should be fixed and made to work.
Related suggestion - I see another section on logging further down. It would be better to combine the sections.
2.Issue number for functools.lru_cache is not mentioned. If no tracker id/ discussion is available, checkin link can be mentioned.
3. There is section for Popen which says, subprocess.Popen() functions now support with statements for auto-closing of the file descriptors. Not really. Only os.popen() function supports it.
4. In the concurrent.futures example, it is given as:
import threading, shutil
with threading.ThreadPoolExecutor(max_workers=4) as e:
It should be:
import concurrent.futures, shutil
with concurrent.futures.ThreadPoolExector(max_workers=4) as e:
Please correct these before the release on 19th. |
|
Date |
User |
Action |
Args |
2011-02-17 16:12:34 | orsenthil | set | recipients:
+ orsenthil, georg.brandl, rhettinger, vinay.sajip, ncoghlan, belopolsky, vstinner, ned.deily, ezio.melotti, eric.araujo, eli.bendersky, daniel.urban |
2011-02-17 16:12:34 | orsenthil | set | messageid: <1297959154.25.0.62189724586.issue11071@psf.upfronthosting.co.za> |
2011-02-17 16:12:33 | orsenthil | link | issue11071 messages |
2011-02-17 16:12:33 | orsenthil | create | |
|