Message 128026 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gregory.p.smith
Recipients	giampaolo.rodola, gregory.p.smith, jwarkentin
Date	2011-02-05.20:59:24
SpamBayes Score	0.0054076244
Marked as misclassified	No
Message-id	<1296939565.14.0.395842306517.issue11109@psf.upfronthosting.co.za>
In-reply-to

Content
Rather than depending on the internal details of ForkingMixIn in your BaseServer.serve_forever modification I'd prefer to see that simply call self._cleanup() Define a do-nothing _periodic_cleanup method in BaseServer. ForkingMixIn should implement its own _periodic_cleanup method that does the active_children test and calls collect_children as appropriate.

Rather than depending on the internal details of ForkingMixIn in your BaseServer.serve_forever modification I'd prefer to see that simply call self._cleanup()

Define a do-nothing _periodic_cleanup method in BaseServer.  ForkingMixIn should implement its own _periodic_cleanup method that does the active_children test and calls collect_children as appropriate.

History
Date	User	Action	Args
2011-02-05 20:59:25	gregory.p.smith	set	recipients: + gregory.p.smith, giampaolo.rodola, jwarkentin
2011-02-05 20:59:25	gregory.p.smith	set	messageid: <1296939565.14.0.395842306517.issue11109@psf.upfronthosting.co.za>
2011-02-05 20:59:24	gregory.p.smith	link	issue11109 messages
2011-02-05 20:59:24	gregory.p.smith	create