Message127859
It may be clearer and match Python coding style better to fix it as follows:
Index: Modules/_sqlite/module.c
===================================================================
--- Modules/_sqlite/module.c (revision 88320)
+++ Modules/_sqlite/module.c (working copy)
@@ -321,14 +321,16 @@
module = PyModule_Create(&_sqlite3module);
- if (!module ||
- (pysqlite_row_setup_types() < 0) ||
- (pysqlite_cursor_setup_types() < 0) ||
- (pysqlite_connection_setup_types() < 0) ||
- (pysqlite_cache_setup_types() < 0) ||
- (pysqlite_statement_setup_types() < 0) ||
- (pysqlite_prepare_protocol_setup_types() < 0)
- ) {
+ if (module == NULL)
+ return NULL;
+
+ if (pysqlite_row_setup_types() < 0 ||
+ pysqlite_cursor_setup_types() < 0 ||
+ pysqlite_connection_setup_types() < 0 ||
+ pysqlite_cache_setup_types() < 0 ||
+ pysqlite_statement_setup_types() < 0 ||
+ pysqlite_prepare_protocol_setup_types() < 0)
+ {
Py_DECREF(module);
return NULL;
} |
|
Date |
User |
Action |
Args |
2011-02-04 02:21:37 | belopolsky | set | recipients:
+ belopolsky, brett.cannon, georg.brandl |
2011-02-04 02:21:37 | belopolsky | set | messageid: <1296786097.38.0.394659083351.issue11110@psf.upfronthosting.co.za> |
2011-02-04 02:21:36 | belopolsky | link | issue11110 messages |
2011-02-04 02:21:36 | belopolsky | create | |
|