This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients belopolsky, brett.cannon, georg.brandl
Date 2011-02-04.02:21:36
SpamBayes Score 1.4282702e-05
Marked as misclassified No
Message-id <1296786097.38.0.394659083351.issue11110@psf.upfronthosting.co.za>
In-reply-to
Content
It may be clearer and match Python coding style better to fix it as follows:


Index: Modules/_sqlite/module.c
===================================================================
--- Modules/_sqlite/module.c	(revision 88320)
+++ Modules/_sqlite/module.c	(working copy)
@@ -321,14 +321,16 @@
 
     module = PyModule_Create(&_sqlite3module);
 
-    if (!module ||
-        (pysqlite_row_setup_types() < 0) ||
-        (pysqlite_cursor_setup_types() < 0) ||
-        (pysqlite_connection_setup_types() < 0) ||
-        (pysqlite_cache_setup_types() < 0) ||
-        (pysqlite_statement_setup_types() < 0) ||
-        (pysqlite_prepare_protocol_setup_types() < 0)
-       ) {
+    if (module == NULL)
+        return NULL;
+
+    if (pysqlite_row_setup_types() < 0 ||
+        pysqlite_cursor_setup_types() < 0 ||
+        pysqlite_connection_setup_types() < 0 ||
+        pysqlite_cache_setup_types() < 0 ||
+        pysqlite_statement_setup_types() < 0 ||
+        pysqlite_prepare_protocol_setup_types() < 0)
+    {
         Py_DECREF(module);
         return NULL;
     }
History
Date User Action Args
2011-02-04 02:21:37belopolskysetrecipients: + belopolsky, brett.cannon, georg.brandl
2011-02-04 02:21:37belopolskysetmessageid: <1296786097.38.0.394659083351.issue11110@psf.upfronthosting.co.za>
2011-02-04 02:21:36belopolskylinkissue11110 messages
2011-02-04 02:21:36belopolskycreate