Author r.david.murray
Recipients amaury.forgeotdarc, barry, eric.araujo, erob, flox, georg.brandl, ggenellina, oopos, pebbe, pitrou, quentel, r.david.murray, tcourbon, tobias, v+python, vstinner
Date 2011-01-13.14:31:47
SpamBayes Score 5.25302e-13
Marked as misclassified No
Message-id <1294929109.94.0.832089464717.issue4953@psf.upfronthosting.co.za>
In-reply-to
Content
It getting in to 3.2 would be a release manager call, so I've set it to release blocker so Georg can make the call.  My opinion is that while I would *really* like to see this fixed in 3.2, the changes really should have a thorough *design* review as well as a code review.  

The argument for putting it in would be that it is broken as is (at least for binary file upload, possibly in other ways as well), and if we can get agreement on the API changes, we can fix any remaining bugs in 3.2.1.  However, making API changes at this point (post-beta) requires a significant exception to our normal development rules, and I don't like doing things this rushed and last minute.  But I also don't like the thought of having FieldStorage be broken in 3.2.

Georg, I'm really busy this week, and don't have time to do a review, unfortunately.  If you think it worth considering putting it in, I can try to take a look at the API changes tomorrow, but unfortunately can make no promise to do so.  Hopefully others can, if needed.
History
Date User Action Args
2011-01-13 14:31:50r.david.murraysetrecipients: + r.david.murray, barry, georg.brandl, amaury.forgeotdarc, ggenellina, pitrou, vstinner, eric.araujo, v+python, oopos, tcourbon, tobias, flox, pebbe, quentel, erob
2011-01-13 14:31:49r.david.murraysetmessageid: <1294929109.94.0.832089464717.issue4953@psf.upfronthosting.co.za>
2011-01-13 14:31:47r.david.murraylinkissue4953 messages
2011-01-13 14:31:47r.david.murraycreate