Author pjcreath
Recipients georg.brandl, ned.deily, pjcreath
Date 2011-01-12.15:31:53
SpamBayes Score 2.72858e-08
Marked as misclassified No
Message-id <1294846329.52.0.817384849698.issue10855@psf.upfronthosting.co.za>
In-reply-to
Content
Thank you for clarifying the documentation.  However, I don't think that fully resolves the issue.

I'm not complaining about a failure to close the file.  As you observe, it doesn't need to (and shouldn't) close a file object, but it should release the reference.

The code already tries to release the reference ("self._file = None").  It just fails to release it correctly, missing the other reference to the file object (self._data_chunk).  That's the bug.

Your clarification of the documentation is appreciated nonetheless.

I've attached a patch as Ned requested.  The same patch can currently be applied to release27-maint, release31-maint, and py3k.  (The line numbers and surrounding context are identical.)
History
Date User Action Args
2011-01-12 15:32:09pjcreathsetrecipients: + pjcreath, georg.brandl, ned.deily
2011-01-12 15:32:09pjcreathsetmessageid: <1294846329.52.0.817384849698.issue10855@psf.upfronthosting.co.za>
2011-01-12 15:31:53pjcreathlinkissue10855 messages
2011-01-12 15:31:53pjcreathcreate