This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author loewis
Recipients belopolsky, georg.brandl, giampaolo.rodola, gregory.p.smith, loewis, pitrou, rosslagerwall
Date 2011-01-06.23:30:05
SpamBayes Score 1.0752962e-09
Marked as misclassified No
Message-id <4D26507C.5010305@v.loewis.de>
In-reply-to <1294324408.87.0.519557321036.issue10812@psf.upfronthosting.co.za>
Content
Patch looks mostly good. Some comments:

- sethostname supports names with embedded null bytes, so
  wrapper should not use strlen
- it's a bit asymmetric that gethostname is in the socket
  module and supports Windows, and sethostname is in the POSIX
  module. It would be useful to have a gethostname in the POSIX
  module also which is a) POSIX only and b) supports embedded
  NUL bytes.
- I think get/sethostname should use the FSDefault encoding.
- gethostid should check for POSIX errors.
- it checks for sethostid but then doesn't implement it.
- parsing id_t with "l" is incorrect, methinks
- siginfo_t should map to a structsequence
- according to my copy of waitid(2), not all of the fields you
  are returning from siginfo_t are actually filled.
- instead of PARSE_OFF_T, I rather recommend to use an O& parser.
History
Date User Action Args
2011-01-06 23:30:08loewissetrecipients: + loewis, georg.brandl, gregory.p.smith, belopolsky, pitrou, giampaolo.rodola, rosslagerwall
2011-01-06 23:30:05loewislinkissue10812 messages
2011-01-06 23:30:05loewiscreate