Author rosslagerwall
Recipients beazley, gregory.p.smith, ned.deily, rosslagerwall, roysmith
Date 2010-12-31.08:14:59
SpamBayes Score 3.11872e-06
Marked as misclassified No
Message-id <1293783316.33.0.448945196387.issue7322@psf.upfronthosting.co.za>
In-reply-to
Content
Attached is a patch which fixes the issue.

Instead of allowing the readline method to lose data, it adds a check to SocketIO.readinto() to ensure that the socket does not have a timeout and throws an IOError if it does. Also does the same for SocketIO.write().

I think this is a better approach - just failing immediately when a readline on a nonblocking socket occurs instead of failing sometimes and losing data.
History
Date User Action Args
2010-12-31 08:15:16rosslagerwallsetrecipients: + rosslagerwall, beazley, gregory.p.smith, roysmith, ned.deily
2010-12-31 08:15:16rosslagerwallsetmessageid: <1293783316.33.0.448945196387.issue7322@psf.upfronthosting.co.za>
2010-12-31 08:15:00rosslagerwalllinkissue7322 messages
2010-12-31 08:15:00rosslagerwallcreate