Message124789
Since the Release Manager agrees with the change, I withdraw my objection.
I have three remarks to the patch:
- Some examples in the documentation should be fixed:
http://docs.python.org/dev/py3k/library/struct.html#examples
>>> pack('ci', '*', 0x12131415)
will now raise an exception.
- the message "argument for 's' must be a bytes" looks a bit weird. "a bytes object" seems better.
- the 'p' format (Pascal String) should be changed as well. This is the last call to _PyUnicode_AsDefaultEncodedString() in this file... |
|
Date |
User |
Action |
Args |
2010-12-28 12:09:59 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, georg.brandl, rhettinger, mark.dickinson, vstinner, r.david.murray, dabeaz |
2010-12-28 12:09:59 | amaury.forgeotdarc | set | messageid: <1293538199.89.0.785194734664.issue10783@psf.upfronthosting.co.za> |
2010-12-28 12:09:57 | amaury.forgeotdarc | link | issue10783 messages |
2010-12-28 12:09:57 | amaury.forgeotdarc | create | |
|