Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, dabeaz, georg.brandl, mark.dickinson, r.david.murray, rhettinger, vstinner
Date 2010-12-28.12:09:57
SpamBayes Score 4.20646e-05
Marked as misclassified No
Message-id <1293538199.89.0.785194734664.issue10783@psf.upfronthosting.co.za>
In-reply-to
Content
Since the Release Manager agrees with the change, I withdraw my objection.

I have three remarks to the patch: 

- Some examples in the documentation should be fixed:
http://docs.python.org/dev/py3k/library/struct.html#examples
>>> pack('ci', '*', 0x12131415)
will now raise an exception.

- the message "argument for 's' must be a bytes" looks a bit weird. "a bytes object" seems better.

- the 'p' format (Pascal String) should be changed as well. This is the last call to _PyUnicode_AsDefaultEncodedString() in this file...
History
Date User Action Args
2010-12-28 12:09:59amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, georg.brandl, rhettinger, mark.dickinson, vstinner, r.david.murray, dabeaz
2010-12-28 12:09:59amaury.forgeotdarcsetmessageid: <1293538199.89.0.785194734664.issue10783@psf.upfronthosting.co.za>
2010-12-28 12:09:57amaury.forgeotdarclinkissue10783 messages
2010-12-28 12:09:57amaury.forgeotdarccreate