➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, brian.curtin, eric.smith, jaraco
Date 2010-12-28.07:53:06
SpamBayes Score 0.00011918254
Marked as misclassified No
Message-id <1293522792.04.0.744697879165.issue9333@psf.upfronthosting.co.za>
In-reply-to
Content 
The patch looks good, I only have stylistic remarks:
- We normally don't use windows-specific types in CPython code. Please use int instead of BOOL. And C variables are usually lowercase, even module globals. I suggest something like "static int win32_can_symlink;"
- the enable_symlink() function should be "static" as well.
History
Date User Action Args
2010-12-28 07:53:12amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, jaraco, eric.smith, brian.curtin
2010-12-28 07:53:12amaury.forgeotdarcsetmessageid: <1293522792.04.0.744697879165.issue9333@psf.upfronthosting.co.za>
2010-12-28 07:53:06amaury.forgeotdarclinkissue9333 messages
2010-12-28 07:53:06amaury.forgeotdarccreate