Message124343
Also, I am not familiar with the backward-comparability requirements of py3k, but orsenthil's patch will break py3k code that relies on data being a string, shouldn't this be mentioned somewhere?
Finally, I do not understand why my proposed change, which is to add
+ if not data:
+ request.add_unredirected_header('Content-length', '0')
so that code that relies on being able to pass a blank string as data (for instance, the code in test_urllib2.py) is still able to do so. |
|
Date |
User |
Action |
Args |
2010-12-19 12:47:12 | xuanji | set | recipients:
+ xuanji, jhylton, georg.brandl, rhettinger, orsenthil, pitrou, catlee, eric.araujo, rcoyner, davide.rizzo |
2010-12-19 12:47:12 | xuanji | set | messageid: <1292762832.19.0.983217019816.issue3243@psf.upfronthosting.co.za> |
2010-12-19 12:47:10 | xuanji | link | issue3243 messages |
2010-12-19 12:47:10 | xuanji | create | |
|