This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author xuanji
Recipients catlee, davide.rizzo, eric.araujo, georg.brandl, jhylton, orsenthil, pitrou, rcoyner, rhettinger, xuanji
Date 2010-12-19.12:47:10
SpamBayes Score 6.7133543e-09
Marked as misclassified No
Message-id <1292762832.19.0.983217019816.issue3243@psf.upfronthosting.co.za>
In-reply-to
Content
Also, I am not familiar with the backward-comparability requirements of py3k, but orsenthil's patch will break py3k code that relies on data being a string, shouldn't this be mentioned somewhere?

Finally, I do not understand why my proposed change, which is to add

+    if not data:
+        request.add_unredirected_header('Content-length', '0')


so that code that relies on being able to pass a blank string as data (for instance, the code in test_urllib2.py) is still able to do so.
History
Date User Action Args
2010-12-19 12:47:12xuanjisetrecipients: + xuanji, jhylton, georg.brandl, rhettinger, orsenthil, pitrou, catlee, eric.araujo, rcoyner, davide.rizzo
2010-12-19 12:47:12xuanjisetmessageid: <1292762832.19.0.983217019816.issue3243@psf.upfronthosting.co.za>
2010-12-19 12:47:10xuanjilinkissue3243 messages
2010-12-19 12:47:10xuanjicreate