➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.araujo
Recipients asampson, bethard, eric.araujo
Date 2010-12-13.09:18:01
SpamBayes Score 0.0056416094
Marked as misclassified No
Message-id <1292231886.43.0.343556393224.issue9234@psf.upfronthosting.co.za>
In-reply-to
Content 
Patch looks good.  Can you add tests for the new functionality?  (This is listed in the link I gave you :)

Note: this code

    if 'aliases' in kwargs:
        aliases = kwargs.pop('aliases')
    else:
        aliases = ()

can be shortened to

    aliases = kwargs.pop('aliases', ())
History
Date User Action Args
2010-12-13 09:18:06eric.araujosetrecipients: + eric.araujo, bethard, asampson
2010-12-13 09:18:06eric.araujosetmessageid: <1292231886.43.0.343556393224.issue9234@psf.upfronthosting.co.za>
2010-12-13 09:18:02eric.araujolinkissue9234 messages
2010-12-13 09:18:01eric.araujocreate