Author milko.krachounov
Recipients Giovanni.Bajo, gregory.p.smith, milko.krachounov, paul.moore
Date 2010-12-10.19:44:28
SpamBayes Score 2.78237e-05
Marked as misclassified No
Message-id <1292010270.39.0.153248664939.issue7213@psf.upfronthosting.co.za>
In-reply-to
Content
> I'm +1 on it, but I think it should be the default; instead, 
> your proposed patch adds a new argument to the public API. Why do you 
> think it's necessary to do so?

I don't think it's necessary. I put it there because when I was testing I thought it might help. For example, you might want to keep the pipes open and then open another process with close_fds=False, thus changing the current default might cause some regressions in some software and an argument would allow an easier transition. I updated the patch removing anything unnecessary. Though it still has a huge race when used with threading.
History
Date User Action Args
2010-12-10 19:44:30milko.krachounovsetrecipients: + milko.krachounov, gregory.p.smith, paul.moore, Giovanni.Bajo
2010-12-10 19:44:30milko.krachounovsetmessageid: <1292010270.39.0.153248664939.issue7213@psf.upfronthosting.co.za>
2010-12-10 19:44:28milko.krachounovlinkissue7213 messages
2010-12-10 19:44:28milko.krachounovcreate