Message123744
> I'm +1 on it, but I think it should be the default; instead,
> your proposed patch adds a new argument to the public API. Why do you
> think it's necessary to do so?
I don't think it's necessary. I put it there because when I was testing I thought it might help. For example, you might want to keep the pipes open and then open another process with close_fds=False, thus changing the current default might cause some regressions in some software and an argument would allow an easier transition. I updated the patch removing anything unnecessary. Though it still has a huge race when used with threading. |
|
Date |
User |
Action |
Args |
2010-12-10 19:44:30 | milko.krachounov | set | recipients:
+ milko.krachounov, gregory.p.smith, paul.moore, Giovanni.Bajo |
2010-12-10 19:44:30 | milko.krachounov | set | messageid: <1292010270.39.0.153248664939.issue7213@psf.upfronthosting.co.za> |
2010-12-10 19:44:28 | milko.krachounov | link | issue7213 messages |
2010-12-10 19:44:28 | milko.krachounov | create | |
|