Author r.david.murray
Recipients Rodrigue.Alcazar, ezio.melotti, ncoghlan, pitrou, r.david.murray
Date 2010-12-06.20:53:16
SpamBayes Score 1.54705e-08
Marked as misclassified No
Message-id <1291668798.51.0.920627273789.issue9517@psf.upfronthosting.co.za>
In-reply-to
Content
I just tried using script_helper in a new test, so I have a couple of comments.

I don't see stdout and stderr being conflated, it looks to me like they are returned separately, at least by the assert methods.

The assert methods return results, which is unlike other assert methods.  This is very useful, even essential, and I wouldn't want to give it up.  That conflicts with the current unittest conventions, though.

It would be a big help if 'err' were returned with the refcount line removed if it is there, which would make tests using the methods return the same 'err' regardless of whether they are run under a debug build or not.

I think the names of the two assert functions should follow the current unit test conventions (assertPythonRunOK and asssertPythonRunNotOK, perhaps?)
History
Date User Action Args
2010-12-06 20:53:18r.david.murraysetrecipients: + r.david.murray, ncoghlan, pitrou, ezio.melotti, Rodrigue.Alcazar
2010-12-06 20:53:18r.david.murraysetmessageid: <1291668798.51.0.920627273789.issue9517@psf.upfronthosting.co.za>
2010-12-06 20:53:16r.david.murraylinkissue9517 messages
2010-12-06 20:53:16r.david.murraycreate