Author eric.araujo
Recipients benjamin.peterson, djc, eric.araujo, georg.brandl, mark.dickinson, meatballhat, techtonik, tim.peters, trentm, ysj.ray
Date 2010-12-03.02:42:53
SpamBayes Score 5.52457e-06
Marked as misclassified No
Message-id <1291344176.43.0.405252148409.issue2142@psf.upfronthosting.co.za>
In-reply-to
Content
To sum up the current consensus as I understand it, the missing end of line is clearly a bug, but the addition of “\No newline at end of file” is controversial.  In the current patch, both are changed, so backporting only the first fix to 3.1 and 2.7 will require either agreeing to add “\No newline etc” in those versions too, or make another patch for 3.1/2.7.

I uploaded the patch to http://codereview.appspot.com/3432041/ and made some minor comments.
History
Date User Action Args
2010-12-03 02:42:56eric.araujosetrecipients: + eric.araujo, tim.peters, georg.brandl, mark.dickinson, techtonik, benjamin.peterson, trentm, djc, meatballhat, ysj.ray
2010-12-03 02:42:56eric.araujosetmessageid: <1291344176.43.0.405252148409.issue2142@psf.upfronthosting.co.za>
2010-12-03 02:42:53eric.araujolinkissue2142 messages
2010-12-03 02:42:53eric.araujocreate