➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author stutzbach
Recipients amaury.forgeotdarc, collinwinter, eric.smith, mark.dickinson, pitrou, rhettinger, stutzbach, terry.reedy, tim.peters
Date 2010-12-02.01:06:17
SpamBayes Score 0.00018146324
Marked as misclassified No
Message-id <1291251979.37.0.0915327850919.issue9915@psf.upfronthosting.co.za>
In-reply-to
Content 
> Just wanted to post this so there weren't any illusions about the
> patch being a big win.

> When a key function is defined, this is all you can possibly shave
> off the time for a comparison.

I don't want to argue whether the patch is a big win or not (I recognize that it is a tradeoff), but when using a key it does shave off more than the call to sortwrapper_richcompare.

Stack with sortwrapper:

long_richcompare
do_richcompare
PyObject_RichCompare
sortwrapper_richcompare
do_richcompare
PyObject_RichCompare
PyObject_RichCompareBool
count_run
list_sort

Stack without:

long_richcompare
do_richcompare
PyObject_RichCompare
PyObject_RichCompareBool
count_run
list_sort
History
Date User Action Args
2010-12-02 01:06:19stutzbachsetrecipients: + stutzbach, tim.peters, collinwinter, rhettinger, terry.reedy, amaury.forgeotdarc, mark.dickinson, pitrou, eric.smith
2010-12-02 01:06:19stutzbachsetmessageid: <1291251979.37.0.0915327850919.issue9915@psf.upfronthosting.co.za>
2010-12-02 01:06:17stutzbachlinkissue9915 messages
2010-12-02 01:06:17stutzbachcreate