Author rhettinger
Recipients amaury.forgeotdarc, collinwinter, eric.smith, mark.dickinson, pitrou, rhettinger, stutzbach, terry.reedy, tim.peters
Date 2010-12-01.23:16:43
SpamBayes Score 1.3879e-09
Marked as misclassified No
Message-id <1291245405.23.0.223483860341.issue9915@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks.  This nice, clean diff is much more reviewable and it looks like what I expected.   

The use of  Py_LOCAL_INLINE is new to me since we usually use #define instead, but this has a cleaner look to it.  I am unclear on whether all the our target compilers support an inline keyword.   If you're sure it works everywhere, that's great.  If not, consider going back to ugly defines -- those reliably work everywhere.

Also note that this patch puts a lot of faith in branch prediction.  If some target processor doesn't support it, or has limited ability to remember predictions, or mispredicts, then the code will be slower.

That being said, I'm happy with the patch.   You have a +1 from me.
History
Date User Action Args
2010-12-01 23:16:45rhettingersetrecipients: + rhettinger, tim.peters, collinwinter, terry.reedy, amaury.forgeotdarc, mark.dickinson, pitrou, eric.smith, stutzbach
2010-12-01 23:16:45rhettingersetmessageid: <1291245405.23.0.223483860341.issue9915@psf.upfronthosting.co.za>
2010-12-01 23:16:43rhettingerlinkissue9915 messages
2010-12-01 23:16:43rhettingercreate