Message122922
The patch includes unittests; the issue is that the tests pass without the changes. That is an entirely different state to be in. The tests should be committed unless somebody wants to object to the behavior that they are testing (although I believe this behavior is already codified in documentation). If the tests start failing on someone's platform, then you have a patch already waiting to be applied. Nevertheless, I don't see the harm in the patch as-is, because it is a quite innocuous change to Py_UniversalNewlineFgets(), unless (again) you want to argue about the correctness of that change despite no test failing. |
|
Date |
User |
Action |
Args |
2010-11-30 17:26:09 | scott.dial | set | recipients:
+ scott.dial, loewis, belopolsky, pitrou, josm, benjamin.peterson, gpolo, BreamoreBoy |
2010-11-30 17:26:08 | scott.dial | set | messageid: <1291137968.93.0.15335536149.issue1706039@psf.upfronthosting.co.za> |
2010-11-30 17:26:06 | scott.dial | link | issue1706039 messages |
2010-11-30 17:26:06 | scott.dial | create | |
|