Author pitrou
Recipients amaury.forgeotdarc, collinwinter, eric.smith, pitrou, rhettinger, stutzbach, terry.reedy, tim.peters
Date 2010-11-23.23:03:57
SpamBayes Score 0.000129824
Marked as misclassified No
Message-id <1290553434.3642.111.camel@localhost.localdomain>
In-reply-to <1290551390.54.0.384750100564.issue9915@psf.upfronthosting.co.za>
Content
> My original patch was much more focused, but had a slightly larger
> performance penalty for sorting random keys (see
> http://bugs.python.org/msg122178).  Do you think the performance
> tradeoff there was still worthwhile?

I am not objecting against the performance tweaks but the other more or
less gratuitous changes (IFLT vs ISLT, Py_LOCAL_INLINE sprinkled all
over, weird complicated static "keys" instead of the initial stack_keys,
"else" style change...).

You can still try to salvage my comments from the review I've posted,
but it seems Rietveld makes the thing tediously annoying to navigate
(best thing may be to browse all 14 side-by-side diffs to look for the
comments).
History
Date User Action Args
2010-11-23 23:03:59pitrousetrecipients: + pitrou, tim.peters, collinwinter, rhettinger, terry.reedy, amaury.forgeotdarc, eric.smith, stutzbach
2010-11-23 23:03:57pitroulinkissue9915 messages
2010-11-23 23:03:57pitroucreate