This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author loewis
Recipients amaury.forgeotdarc, jonny, loewis, rpetrov
Date 2010-11-22.23:12:54
SpamBayes Score 2.77127e-09
Marked as misclassified No
Message-id <4CEAF8F5.1020101@v.loewis.de>
In-reply-to <1290465768.67.0.860290890585.issue10504@psf.upfronthosting.co.za>
Content
> I doubt this fix will be enough to fix compilation with mingw32.

So somebody will have to verify independently. If it fails to fix
the bug completely, it's out of scope for 2.7 (it's out of scope for
2.7.1 IMO either way).

> With this patch, "#ifdef MS_WINDOWS" has the meaning of "linked with
> some version of MSVCRT". Do we agree on this, or is another symbol
> necessary?

MS_WINDOWS is defined as

MS_WINDOWS - Code specific to Windows, but all versions.

So it does *not* imply "MSVCRT". Introducing a new preprocessor symbol
is also out of scope for 2.7, so if we mean "MSC or mingw", we need
to spell that out (i.e. defined(_MSC_VER) || defined(__MINGW32__)).
History
Date User Action Args
2010-11-22 23:12:56loewissetrecipients: + loewis, amaury.forgeotdarc, rpetrov, jonny
2010-11-22 23:12:54loewislinkissue10504 messages
2010-11-22 23:12:54loewiscreate