Message121845
Yeah a new test class is fine.
And I checked the patch and it looks okay to me. My first thought was also "wait does that really work?" but I see that positionals are all marked as required when appropriate (look for the comment starting with "mark positional arguments as required").
I don't have time to test the patch right now, but if someone else does, I'm fine with this after the test for the new behavior is added. |
|
Date |
User |
Action |
Args |
2010-11-21 03:06:47 | bethard | set | recipients:
+ bethard, ezio.melotti, eric.araujo, r.david.murray, maker |
2010-11-21 03:06:47 | bethard | set | messageid: <1290308807.19.0.794584626411.issue10424@psf.upfronthosting.co.za> |
2010-11-21 03:06:45 | bethard | link | issue10424 messages |
2010-11-21 03:06:45 | bethard | create | |
|