Author roysmith
Recipients beazley, gregory.p.smith, ned.deily, roysmith
Date 2010-11-21.02:36:03
SpamBayes Score 8.30121e-06
Marked as misclassified No
Message-id <>
This is kind of ugly.  On the one hand, I'm all for adding a check in makefile() to catch it being called on a non-blocking socket.

On the other hand, you are correct that a user could change the mode leter.  Even if we added checks for this in socket.setblocking(), there's plenty of ways to get around that; it's easy to grab a raw file descriptor and do whatever you want with it behind the library's back.

On the third hand, maybe a check could be added to SocketIO.readinto() to verify that the socket was in blocking mode each time it was called?
Date User Action Args
2010-11-21 02:36:06roysmithsetrecipients: + roysmith, beazley, gregory.p.smith, ned.deily
2010-11-21 02:36:06roysmithsetmessageid: <>
2010-11-21 02:36:03roysmithlinkissue7322 messages
2010-11-21 02:36:03roysmithcreate