➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.araujo
Recipients BreamoreBoy, brett.cannon, dstanek, elesbom, eric.araujo, jesstess, pitrou, r.david.murray, roysmith, thomas.holmes
Date 2010-11-20.20:43:41
SpamBayes Score 0.0027421215
Marked as misclassified No
Message-id <1290285827.54.0.337966582533.issue7325@psf.upfronthosting.co.za>
In-reply-to
Content 
Looks good to me, with one exception:

 if temp_dir_abspath.startswith('./'):

Wouldn’t this be better:

 if not _os.path.isabs(temp_dir_abspath)

(P.S. file is not a builtin anymore in 3.x, it’s used for example as an argument to the print function.)
History
Date User Action Args
2010-11-20 20:43:47eric.araujosetrecipients: + eric.araujo, brett.cannon, roysmith, pitrou, dstanek, r.david.murray, jesstess, thomas.holmes, BreamoreBoy, elesbom
2010-11-20 20:43:47eric.araujosetmessageid: <1290285827.54.0.337966582533.issue7325@psf.upfronthosting.co.za>
2010-11-20 20:43:41eric.araujolinkissue7325 messages
2010-11-20 20:43:41eric.araujocreate