Author Mick.Beaver
Recipients Mick.Beaver, georg.brandl
Date 2010-11-20.14:00:46
SpamBayes Score 0.000196732
Marked as misclassified No
Message-id <AANLkTinPLXNWmARh57gja3af=UuoakksbfpxAzRy59rV@mail.gmail.com>
In-reply-to <1290253659.5.0.605792923637.issue10460@psf.upfronthosting.co.za>
Content
Georg,

Thanks for looking at this. Before getting your response, I decided to
take a crack at it and came up with something different. We explicitly
disagree on:

1. You had --no-blank-lines-after-declarations, but PEP 7 says:
- Function definition style: function name in column 1, outermost
      curly braces in column 1, blank line after local variable
      declarations.

2. You had --cuddle-else, but PEP 7 has the following listing:
if (mro != NULL) {
    ...
}
else {
    ...
}

I merged our two indent.pro files. Between the two of us, we had a
number of switches that were inferred, and should probably be made
more explicit in PEP 7. Those are:
--braces-on-struct-decl-line
--comment-indentation25
--swallow-optional-blank-lines

How do you feel about the following indent.pro?:

--blank-lines-after-declarations
--blank-lines-after-procedures
--braces-after-func-def-line
--braces-on-if-line
--braces-on-struct-decl-line
--break-after-boolean-operator
--comment-indentation25
--comment-line-length79
--continue-at-parentheses
--dont-cuddle-do-while
--dont-cuddle-else
--indent-level4
--line-length79
--no-space-after-casts
--no-space-after-function-call-names
--no-space-after-parentheses
--no-tabs
--procnames-start-lines
--space-after-for
--space-after-if
--space-after-while
--swallow-optional-blank-lines
-T PyCFunction
-T PyObject

Thanks for your help,
Mick
History
Date User Action Args
2010-11-20 14:00:47Mick.Beaversetrecipients: + Mick.Beaver, georg.brandl
2010-11-20 14:00:46Mick.Beaverlinkissue10460 messages
2010-11-20 14:00:46Mick.Beavercreate