Author amaury.forgeotdarc
Recipients BreamoreBoy, LRN, WhiteTiger, amaury.forgeotdarc, davidfraser, eric.araujo, giampaolo.rodola, lkcl, rpetrov, rschoon.old, tarek, zooko
Date 2010-11-12.22:59:24
SpamBayes Score 2.19349e-07
Marked as misclassified No
Message-id <1289602766.4.0.473835828527.issue3871@psf.upfronthosting.co.za>
In-reply-to
Content
I'm trying to read the patch. It contains many interesting things (and others I have no opinon about), but it is very large, and makes it difficult to comment or find why some change were made etc.

I do believe that better supporting the mingw32 platform is a worthy goal, but a single large patch, even after review, is something difficult to trust.

I suggest to present this work in another form. Maybe something like a Mercurial Patch Queue?  This would give us a collection of smaller patches, each with its own interest.  Each one can be discussed, modified, reviewed separately and by different people. Large easy tasks (like a massive rename) are distinct from small-but-hard changes. And when something is updated, the reviewers don't have to parse the whole file again; they just look at the recent patches.

As an example: among the many changes, you had to handle the Modules/getpath.c vs. PC/getpathp.c inconsistency.  You chose to have both filenames in the Makefile, but in my opinion it would be better to try to merge the files.
History
Date User Action Args
2010-11-12 22:59:26amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, lkcl, zooko, davidfraser, giampaolo.rodola, tarek, eric.araujo, rpetrov, rschoon.old, WhiteTiger, BreamoreBoy, LRN
2010-11-12 22:59:26amaury.forgeotdarcsetmessageid: <1289602766.4.0.473835828527.issue3871@psf.upfronthosting.co.za>
2010-11-12 22:59:25amaury.forgeotdarclinkissue3871 messages
2010-11-12 22:59:24amaury.forgeotdarccreate