Message120857
urlunparse(url or params = bytes object) produces a result
with the repr of the bytes object if params is set.
urllib.parse.urlunparse(['http', 'host', '/dir', b'params', '', ''])
--> "http://host/dir;b'params'"
That's confusing since urllib/parse.py goes to a lot of trouble to
support both bytes and str. Simplest fix is to only accept str:
Index: Lib/urllib/parse.py
@@ -219,5 +219,5 @@ def urlunparse(components):
scheme, netloc, url, params, query, fragment = components
if params:
- url = "%s;%s" % (url, params)
+ url = ';'.join((url, params))
return urlunsplit((scheme, netloc, url, query, fragment))
Some people at comp.lang.python tell me code shouldn't anyway do str()
just in case it is needed like urllib does, not that I can make much
sense of that discussion. (Subject: harmful str(bytes)).
BTW, the str vs bytes code doesn't have to be quite as painful as in
urllib.parse. Here is a patch which just rearranges and factors out
some code.
http://bugs.python.org/file19525/parse.diff |
|
Date |
User |
Action |
Args |
2010-11-09 10:37:30 | hfuru | set | recipients:
+ hfuru, ncoghlan, orsenthil, pitrou, vstinner, eric.smith, eric.araujo, r.david.murray, sjt |
2010-11-09 10:37:29 | hfuru | set | messageid: <1289299049.91.0.838429042617.issue9873@psf.upfronthosting.co.za> |
2010-11-09 10:37:27 | hfuru | link | issue9873 messages |
2010-11-09 10:37:26 | hfuru | create | |
|