Author r.david.murray
Recipients BreamoreBoy, Red HamsterX, ajaksu2, amaury.forgeotdarc, eric.araujo, pitrou, r.david.murray, sanxiyn
Date 2010-11-08.21:29:47
SpamBayes Score 0.00101052
Marked as misclassified No
Message-id <1289251792.0.0.898508479726.issue1466065@psf.upfronthosting.co.za>
In-reply-to
Content
Here is an updated patch that addresses the concerns I noted.  I modified the tests: given that I've changed the code to raise binascii.Error as discussed, we don't really care from an API point of view what the error text is, just that the error is raised in the cases given.  Nor do we care (again, from an API point of view) if the first error detected is the invalid character or the invalid padding.  

I made the new test test the validate=False case, so all of the invalid character tests are now correctly padded if you ignore the invalid characters.
History
Date User Action Args
2010-11-08 21:29:52r.david.murraysetrecipients: + r.david.murray, amaury.forgeotdarc, sanxiyn, pitrou, ajaksu2, eric.araujo, Red HamsterX, BreamoreBoy
2010-11-08 21:29:52r.david.murraysetmessageid: <1289251792.0.0.898508479726.issue1466065@psf.upfronthosting.co.za>
2010-11-08 21:29:50r.david.murraylinkissue1466065 messages
2010-11-08 21:29:49r.david.murraycreate