Author ncoghlan
Recipients BreamoreBoy, belopolsky, eric.araujo, georg.brandl, giampaolo.rodola, ncoghlan, ping, r.liebscher, ron_adam, srid
Date 2010-11-07.14:17:24
SpamBayes Score 1.60433e-12
Marked as misclassified No
Message-id <1289139447.0.0.0127891503828.issue2001@psf.upfronthosting.co.za>
In-reply-to
Content
I'd actually started typing out the command to commit this before it finally clicked that the patch changes public APIs of the pydoc module in incompatible ways. Sure, they aren't documented, but the fact they aren't protected by an underscore means I'm not comfortable with the idea of removing them or radically change their functionality without going through a deprecation period first.

I've attached my version of the patch which includes some additional documentation cleanups and a tweak to test_pyclbr (since the pydoc changes broke that test through no fault of their own).

However, the public (albeit undocumented) nature of the APIs implementing the old Tk GUI means I'm not comfortable committing the patch in a form that simply drops them without going through a deprecation period first.

So, the way forward from here:
1. The good news is beta 1 has been pushed back to December 4 for other reasons, so there's still more time to work on this
2. The gui() function should still open the Tkinter GUI, and the -g option should be retained with its old functionality. Invoking this function should trigger DeprecationWarning.
3. A serve() function to start the web server component should be added back in
4. The new behaviour of opening the web client can be provided as a "browse()" function (that accepts the port number the server is listening on as an argument).
History
Date User Action Args
2010-11-07 14:17:27ncoghlansetrecipients: + ncoghlan, ping, georg.brandl, belopolsky, giampaolo.rodola, ron_adam, eric.araujo, r.liebscher, srid, BreamoreBoy
2010-11-07 14:17:27ncoghlansetmessageid: <1289139447.0.0.0127891503828.issue2001@psf.upfronthosting.co.za>
2010-11-07 14:17:25ncoghlanlinkissue2001 messages
2010-11-07 14:17:24ncoghlancreate