This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients Tom.OConnor, akitada, eric.smith, mark.dickinson, skrah
Date 2010-11-07.13:08:18
SpamBayes Score 2.3312414e-06
Marked as misclassified No
Message-id <1289135300.81.0.273406643095.issue10052@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch.  This looks fine, in principle.

A couple of comments and questions:

(1) I think the patch should provide *MIN values alongside the *MAX values (for signed types only, of course).

(2) Are we sure that these values are valid on all FreeBSD 4 platforms, or should these definitions be further restricted to Free BSD 4 / x86?

(3) Are the types of the constants definitely correct?  E.g., UINT64_MAX should have type uint64_t.  That gets a bit tricky, since we can't use casts (which would prevent these constants being used in preprocessor #ifs), so we need to determine exactly what basic types uint32_t and uint64_t match, and make sure to use the correct suffix (e.g., ULL, LL, UL, L).  For uint32_t I guess this is easy:  it'll almost certainly be the same type as unsigned int.  Is uint64_t defined as unsigned long long, or as unsigned long?
History
Date User Action Args
2010-11-07 13:08:20mark.dickinsonsetrecipients: + mark.dickinson, eric.smith, akitada, skrah, Tom.OConnor
2010-11-07 13:08:20mark.dickinsonsetmessageid: <1289135300.81.0.273406643095.issue10052@psf.upfronthosting.co.za>
2010-11-07 13:08:19mark.dickinsonlinkissue10052 messages
2010-11-07 13:08:18mark.dickinsoncreate