Author r.david.murray
Recipients bethard, catherine, guandalino, r.david.murray
Date 2010-10-30.14:03:51
SpamBayes Score 6.50021e-06
Marked as misclassified No
Message-id <1288447433.09.0.416446345121.issue9340@psf.upfronthosting.co.za>
In-reply-to
Content
I've looked over this patch, and it seems to me that there is no compelling reason to create two new functions.  I think it would be clearer to just inline that code in the places it is used.  If it turns out later that the code needs to be reused elsewhere, it can be factored out at that time.  (Also, as it stands the methods are being made part of the public API, and that doesn't look right to me.)

Catherine, if you'd like to update the patch that would be great.  Otherwise we will hopefully get to it during the upcoming bug weekend.
History
Date User Action Args
2010-10-30 14:03:53r.david.murraysetrecipients: + r.david.murray, bethard, catherine, guandalino
2010-10-30 14:03:53r.david.murraysetmessageid: <1288447433.09.0.416446345121.issue9340@psf.upfronthosting.co.za>
2010-10-30 14:03:51r.david.murraylinkissue9340 messages
2010-10-30 14:03:51r.david.murraycreate