Author tzot
Recipients docs@python, rhettinger, tzot
Date 2010-10-21.00:40:50
SpamBayes Score 0.000383988
Marked as misclassified No
Message-id <1287621653.02.0.326065744057.issue10160@psf.upfronthosting.co.za>
In-reply-to
Content
An explanation to the changes.

The old code kept the operator.itemgetter arguments in the ag->attr member. If the argument count (ag->nattrs) was 1, the single argument was kept; if more than 1, a tuple of the original arguments was kept.

On every attrgetter_call call, if ag->nattrs was 1, dotted_getattr was called with the plain ag->attr as attribute name; if > 2, dotted_getattr was called for every one of the original arguments.

Now, ag->attr is always a tuple, containing either dotless strings or tuples of dotless strings:

operator.attrgetter("name1", "name2.name3", "name4")

stores ("name1", ("name2", "name3"), "name4") in ag->attr.

dotted_getattr accordingly chooses based on type (either str or tuple, ensured by attrgetter_new) whether to do a single access or a recursive one.
History
Date User Action Args
2010-10-21 00:40:53tzotsetrecipients: + tzot, rhettinger, docs@python
2010-10-21 00:40:53tzotsetmessageid: <1287621653.02.0.326065744057.issue10160@psf.upfronthosting.co.za>
2010-10-21 00:40:51tzotlinkissue10160 messages
2010-10-21 00:40:50tzotcreate