This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients karaken12, r.david.murray, tarek
Date 2010-10-02.15:21:08
SpamBayes Score 4.0459913e-11
Marked as misclassified No
Message-id <1286032870.35.0.83985001568.issue10016@psf.upfronthosting.co.za>
In-reply-to
Content
You are right that this needs to be tested on other platforms.  In order to so test it (and in any case!), the patch will need unit tests.  It also needs doc updates.

In general patch itself looks good to me, modulo the concern you raise about truncate.  You could move the '\0'*buflen constant outside the loop.  Also, the py3k IO module doesn't define constants for 'seek', the docs just refer to the integers, so it might be best not to use the os constants even though they are equivalent (the new io module is not a wrapper around os functions the way the old file implementation was).

FYI, patches should (currently, pending the hg migration) be against the py3k trunk, and whoever commits it would backport it if appropriate.  In this case, however, it is a new feature and so can only go into py3k trunk.
History
Date User Action Args
2010-10-02 15:21:10r.david.murraysetrecipients: + r.david.murray, tarek, karaken12
2010-10-02 15:21:10r.david.murraysetmessageid: <1286032870.35.0.83985001568.issue10016@psf.upfronthosting.co.za>
2010-10-02 15:21:08r.david.murraylinkissue10016 messages
2010-10-02 15:21:08r.david.murraycreate