Message 117279 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	gregory.p.smith, ocean-city, pitrou
Date	2010-09-24.12:47:45
SpamBayes Score	3.9716465e-06
Marked as misclassified	No
Message-id	<1285332468.48.0.304694944257.issue9929@psf.upfronthosting.co.za>
In-reply-to

Content
You are right that it doesn't work anymore (under Linux too). Your patch is almost ok. It should raise a ValueError if bufsize=0 and universal_newlines is true (the two can't be satisfied together, since universal newlines implies buffering). It would also be better to add a test in test_subprocess. As a sidenote, bufsize=1 (line buffering) doesn't work anymore either, and this can't be fixed without breaking compatibility.

You are right that it doesn't work anymore (under Linux too).

Your patch is almost ok. It should raise a ValueError if bufsize=0 and universal_newlines is true (the two can't be satisfied together, since universal newlines implies buffering).

It would also be better to add a test in test_subprocess.

As a sidenote, bufsize=1 (line buffering) doesn't work anymore either, and this can't be fixed without breaking compatibility.

History
Date	User	Action	Args
2010-09-24 12:47:51	pitrou	set	recipients: + pitrou, gregory.p.smith, ocean-city
2010-09-24 12:47:48	pitrou	set	messageid: <1285332468.48.0.304694944257.issue9929@psf.upfronthosting.co.za>
2010-09-24 12:47:46	pitrou	link	issue9929 messages
2010-09-24 12:47:45	pitrou	create