This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients docs@python, jyasskin, mark.dickinson, mattheww, rhettinger
Date 2010-09-08.20:52:07
SpamBayes Score 3.1485172e-08
Marked as misclassified No
Message-id <1283979130.47.0.636947330453.issue9802@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch!

Comments:

(1) Shouldn't 'reverse=True' be omitted in the second doc addition?

(2) I'd also suggest adding a brief comment about what this means for distinct, but equal, objects;  otherwise it's not really obvious what the point of the doc addition is.

(3) As a matter of clarity, perhaps replace "this is" with "max(iterable, key=key) is", and similarly for min.

As an aside, I still like Jeffrey Yasskin's suggestion on the python-dev mailing list that the sensible definition for max would maintain the invariant that max(iterable) be equivalent to sorted(iterable)[-1];  see Alexander Stepanov's writings in e.g., http://www.cs.rpi.edu/~musser/gsd/notes-on-programming-2006-10-13.pdf for more.  But that's (a) another issue, and (b) perhaps not a significant enough benefit to be worth changing Python's semantics for.
History
Date User Action Args
2010-09-08 20:52:10mark.dickinsonsetrecipients: + mark.dickinson, rhettinger, mattheww, jyasskin, docs@python
2010-09-08 20:52:10mark.dickinsonsetmessageid: <1283979130.47.0.636947330453.issue9802@psf.upfronthosting.co.za>
2010-09-08 20:52:07mark.dickinsonlinkissue9802 messages
2010-09-08 20:52:07mark.dickinsoncreate