This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author lemburg
Recipients Arfrever, lemburg, pitrou, vstinner
Date 2010-08-18.10:33:45
SpamBayes Score 4.4855786e-12
Marked as misclassified No
Message-id <4C6BB703.10306@egenix.com>
In-reply-to <1282093525.41.0.440562307181.issue8622@psf.upfronthosting.co.za>
Content
STINNER Victor wrote:
> 
> STINNER Victor <victor.stinner@haypocalc.com> added the comment:
> 
> Here you have a patch. It adds tests in test_sys.
> 
> The tests are skipped on a non-ascii Python executable path because of #8611 (see #9425).

Thanks for the patch.

A couple of notes:

 * The command line -h explanation is missing from the patch.

 * The documentation should mention that the env var is only
   read once; subsequent changes to the env var are not seen
   by Python

 * If the codec lookup fails, Python should either issue a warning
   and then ignore the env var (using the get_codeset() API).

 * Unrelated to the env var, but still important: if get_codeset()
   does not return a known codec, Python should issue a warning
   before falling back to the default setting. Otherwise, a
   Python user will never know that there's an issue and this
   make debugging a lot harder.

We should also add a new sys.setfilesystemencoding()
function to make changes possible after Python startup. This
would have to go on a separate ticket, though. Or is there
some concept preventing this ?
History
Date User Action Args
2010-08-18 10:33:47lemburgsetrecipients: + lemburg, pitrou, vstinner, Arfrever
2010-08-18 10:33:46lemburglinkissue8622 messages
2010-08-18 10:33:45lemburgcreate